sillsdev / silkin

Kinship Analysis software for field workers in Anthropology and Bible translation
http://www.sil.org/resources/software_fonts/silkin
4 stars 1 forks source link

Missing children in Details panel for a union #16

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
This primarily concerns twins.

First of all, there were three children who were born posthumously to a 
deceased husband. In the Details panel for the deceased husband's union, these 
children are not listed as they appear in the Details panel for the biological 
union that produced them. So, for now I have copied this information into the 
'Notes on this Family' window (see screen shot attached).

However! When I went to copy the names and ID number of the three children 
concerned, ID#12 was not listed in the Details panel for the union that 
produced him. I think the reason is as follows:
ID 12 and ID 13 are twins and therefore share the same birth date. Therefore, 
only the second twin is shown. See screen shot attached.

Minor issue: in order to take the first screen shot attached here (showing 
notes about posthumous children), I hit 'enter' after each line of information 
I added in the 'Notes on this Family' window. However, the enter isn't 
respected once you go elsewhere (to another union or alter, for example). So 
all the data is now in one line and you have to use the scroll bar to view it. 
It would be nice if 'enter' commands could be respected so that date is nicely 
visible. See screen shot attached. (I noticed this for the 'Notes on Alter' 
window too, but as there's no scroll bar, all the information is visible so it 
didn't bother me as much).

Original issue reported on code.google.com by idani_na...@yahoo.co.uk on 16 Nov 2011 at 8:42

Attachments:

GoogleCodeExporter commented 8 years ago
You are correct that 'Enter' characters (aka newline, return) were not allowed 
in the Comments fields of Individuals or Families. You make a good case for 
their use, so I have added a code/decode feature (they can't be stored in the 
SILK file or it messes up the read/write process). 'Enter' characters now 
persist after entry.

You are correct that identical birthdays for the twins trigger the display 
problem. I propose to correct the display of children with this logic:
1  If all children have a birth date, display in birth order (eldest first)
2  If 0 or 1 have a birth date, display in serial number4 order.
3  If 2+ have birth dates, but not all children, then first display the children
   with birth dates, eldest first. Then display the other children in serial number
   order.

Original comment by garymorr...@verizon.net on 1 Dec 2011 at 6:42

GoogleCodeExporter commented 8 years ago
The algorithm above has been implemented and tested. This affects only the 
listing of children in a Family Details Panel. The drawing of children on the 
chart is not affected. (Children are wherever you place them.)

Original comment by garymorr...@verizon.net on 5 Dec 2011 at 12:11

GoogleCodeExporter commented 8 years ago
Have verified that the two new issues are now fixed (twins showing in the 
details panel of the biological union & 'enter' now recognised when entering 
notes) in the SILKin version 1.0 new release, which included the Claire MQL 
file.

Original comment by idani_na...@yahoo.co.uk on 21 Jan 2012 at 4:55