search

sillsdev / silnlp

A set of pipelines for performing experiments on various NLP tasks with a focus on resource-poor/minority languages.
Other
35 stars 3 forks source link

Adafactor option is deprecated #390

Open jcuenod opened 5 months ago

jcuenod commented 5 months ago

I was wondering why both optim and adafactor were options in the config file.

After some digging, turns out that the adafactor option is deprecated in favor of optim:

https://github.com/huggingface/transformers/blob/main/src/transformers/training_args.py#L1645

Not much work to do in this repo, but maybe you can drop this line (and remove it from any default configs that you pass around):

https://github.com/sillsdev/silnlp/blob/deaf7695e48bc4819cc342a089d0cb3eff71d17e/silnlp/nmt/hugging_face_config.py#L134

ddaspit commented 5 months ago

Thanks for investigating this. We will remove it.

jcuenod commented 5 months ago

Just a note that the wiki should also be updated: https://github.com/sillsdev/silnlp/wiki/Configure-a-model#params