sillsdev / silnlp

A set of pipelines for performing experiments on various NLP tasks with a focus on resource-poor/minority languages.
Other
35 stars 3 forks source link

Issue 473: change xri script to run as a module and rename #506

Closed rminsil closed 2 months ago

rminsil commented 2 months ago

This PR addresses 2 of the points raised in the code review feedback from Damien from this comment:

https://github.com/sillsdev/silnlp/pull/491#pullrequestreview-2261754354

I will address the other point about output location in a follow up PR to make review easier. (I didn't want to rename a file and also change the code, but it looks like github's diff view actually does a good job of teasing those things apart)


This change is Reviewable