search

sillsdev / silnlp

A set of pipelines for performing experiments on various NLP tasks with a focus on resource-poor/minority languages.
Other
35 stars 3 forks source link

Check that necessary files and folders exist after arguments are parsed. #516

Closed davidbaines closed 2 months ago

davidbaines commented 2 months ago

Check that necessary files and folders exist after arguments are parsed. This ensures that necessary files exist before we create a job on clearml and gives the user more immediate feedback when there are typos in the command line.

This change is Reviewable

isaac091 commented 2 months ago

For the translate script, it would probably be good to not check for the source project if args.src_project is None. When no value is passed for the source project, it defaults to the one in the config file, but the name of that project won't be retrieved until after the ClearML Task is created.

isaac091 commented 2 months ago

I'm also not sure that you would be able to check for an experiment or project's existence before attempting to copy it from the bucket, at least not when using the S3 bucket directly rather than via a local mounted drive.

davidbaines commented 2 months ago

I think you're right Isaac. I'll have to rethink this.