search

sillsdev / silnlp

A set of pipelines for performing experiments on various NLP tasks with a focus on resource-poor/minority languages.
Other
35 stars 3 forks source link

Script utils update #545

Closed isaac091 closed 1 month ago

isaac091 commented 1 month ago

Besides the things described in the issue, I renamed get_script to predict_script_code to indicate that it's just a heuristic and moved the specific script disambiguation logic there.

Closes #536

This change is Reviewable

isaac091 commented 1 month ago

@mshannon-sil I don't want to mess with the changes you're making to the environment setup (this PR adds a library), so let me know if it would be better to merge this before or after your changes, or if it doesn't matter.