search

sillsdev / silnlp

A set of pipelines for performing experiments on various NLP tasks with a focus on resource-poor/minority languages.
Other
35 stars 3 forks source link

Incorrect Versification Warning #563

Closed bhartmoore closed 3 weeks ago

bhartmoore commented 1 month ago

In extracting project BUR_2024_10_14, the extract_corpora script gives a warning that the versification is incorrectly set to 0, and that detected versification is 4. However, the settings file includes the line <Versification>4</Versification> (and no other competing versification line).

ddaspit commented 1 month ago

@mshannon-sil Please take a look at this as soon as you have a chance.

mshannon-sil commented 1 month ago

@bhartmoore @ddaspit I took a look, and there's a custom.vrs file that is modifying the base versification. So even though the Settings.xml is set to 4, the FileParatextProjectSettingsParser sets the versification type to 0 (unknown) to reflect this, while setting the base versification type to 4. Given this, would you like to keep the current behavior, or is there an update you'd like to see for this to be more informative/helpful?

mshannon-sil commented 3 weeks ago

From a separate email conversation, we decided that for custom versifications, we can check the detected versification against the base versification type.