sillsdev / silnlp

A set of pipelines for performing experiments on various NLP tasks with a focus on resource-poor/minority languages.
Other
35 stars 3 forks source link

check base versification of custom versification before throwing warning #569

Closed mshannon-sil closed 3 weeks ago

mshannon-sil commented 3 weeks ago

This PR fixes #563 where, during the extract corpora process, the presence of a custom.vrs file would always cause the check_versification function to return a warning that the settings versification type does not match the detected versification type. Now, the function also checks whether the settings versification type is unknown, and if so, it compares the detected versification type against the settings base versification type and only raises a warning if those also don't match.


This change is Reviewable