search

sillsdev / solid

Solid is a software tool that can be used to check, clean up, and convert Standard Format (e.g. Toolbox) lexicon data.
MIT License
1 stars 2 forks source link

Upgrade from .NET 4.6.1 to 4.8.1 #34

Closed megahirt closed 2 months ago

megahirt commented 2 months ago

Upgrad to .Net Framework 4.8.1 from @ethnos-men

ethnos-men commented 2 months ago

@hahn-kev : Thank you for the feedback. I agree with the proposals.

How to proceed? Need the suggested changes to be added to a commit in the net481 Featurebranch or how are they added to the pull request?

I am not familiar with the process in Github Pullrequests.

If it is not much work for you, you could just do the changes in my opinion. Otherwise I can also do them when you tell me where to commit (question above).

megahirt commented 2 months ago

Hi @ethnos-men , no worries. I fixed up your previous git branch and also created a new PR. You should checkout the net481 branch that you created, then commit the change on that branch and push. The PR will be updated automatically.

megahirt commented 2 months ago
image

If you are like me and prefer a nice visual GUI for managing git commits/branches, I recommend GitKraken. It's free for public repos like this one.

hahn-kev commented 2 months ago

@hahn-kev : Thank you for the feedback. I agree with the proposals.

How to proceed? Need the suggested changes to be added to a commit in the net481 Featurebranch or how are they added to the pull request?

I am not familiar with the process in Github Pullrequests.

If it is not much work for you, you could just do the changes in my opinion. Otherwise I can also do them when you tell me where to commit (question above).

No problem.

The typical PR workflow is a bit messed up in this case as Chris created this PR so you can't push changes so it.

Normally though you would just be able to push changes to your branch for this PR and then we will be able to review those changes.

ethnos-men commented 2 months ago

Ok. Thanks. I will take a look later...

ethnos-men commented 2 months ago

Suggestions should be worked in now.

megahirt commented 2 months ago

Once @hahn-kev marks this as approved I am happy to have this merged in. I will then create a new release and test out the new installer.

hahn-kev commented 2 months ago

@megahirt can we not build and test the installer before we merge?

megahirt commented 2 months ago

@megahirt can we not build and test the installer before we merge?

technically, yes, we can do this by pushing a tag starting with v on the branch, and that should generate the installer / release. Could also make the installer locally but would prefer to leave CI to do that. Either way, it involves pushing a tag. If I do that on a branch and I'm happy with it, I would delete the branch and sample tag, and then re-push a new tag for the real publish. If I do it on master and I'm happy with it, then I'd just leave it where it was. In either failure case, I would delete the tag and fix up whatever needs fixing.

megahirt commented 2 months ago

I will go ahead and push a new v1.0.2 tag to this branch and see how that goes.

megahirt commented 2 months ago

I have given this a brief test, and things appear to work as expected. The only note I have is that the installer .exe name is "SolidInstaller-{AppVersion}.exe" -- this is likely because the artifact built on a branch.

Thanks @josephmyers for testing!

I'm pretty sure that the GHA itself is not quite right. I remember this being an issue that I didn't figure out before moving on.