Disable adding custom fields in LF

sillsdev / web-languageforge

Language Forge: Online Collaborative Dictionary Building on the Web and Phone.

https://languageforge.org

MIT License

44 stars 29 forks source link

Disable adding custom fields in LF #1340

Closed rmunn closed 2 years ago

rmunn commented 2 years ago

In #1248, we discovered that custom fields created in Language Forge were not making it through the Send/Receive process properly. I remember looking at the Language Forge custom field code a few years ago when I was implementing Send/Receive for custom fields, and my general impression was that LF's code for editing custom fields is, to put it bluntly, a mess. I propose that we turn off the ability to add or edit custom fields in Language Forge for Send/Receive projects, and replace that UI with a simple message saying "Please use FieldWorks to edit custom fields".

rmunn commented 2 years ago

A note about custom fields should also be added to the "Known Issues and Limitations" in the wiki,

megahirt commented 2 years ago

I totally agree with this assessment. Let's disable the UI for creating / editing custom fields entirely.

[ ] remove the + button for adding entry level custom fields
[ ] remove the + button for adding sense level custom fields
[ ] remove the + button for adding example level custom fields

The above simply removes the capability for the user.

Optional and more extensive changes

[ ] delete UI code associated with the + button press above, including the modal dialog
[ ] If it exists, delete PHP code associated with creating custom fields