Update npm packages - Githubissues

rmunn commented 6 months ago

Fixes #1798

Description

Updated NPM packages by running npm up. This did not update all packages, because in some cases we've put fixed version numbers into package.json rather than versions like ^1.2 which would pull any 1.x package. But this is a start.

Also had to add one line to tsconfig.json, because our suppressImplicitAnyIndexErrors config is deprecated since Typescript 5.0 and will go away in Typescript 5.5. But this PR updates to Typescript 5.4.5, so we don't (yet) have to go through and add individual @ts-ignore comments before each occurrence of implicit "any" types. That's coming soon, though.

Screenshots

No behavioral changes.

Checklist

[X] I have labeled my PR with: bug, feature, engineering, security fix or testing
[X] I have performed a self-review of my own code
[X] I have reviewed the title & description of this PR which I will use as the squashed PR commit message
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have enabled auto-merge (optional)

Testing

Run make, make sure site still loads.

github-actions[bot] commented 6 months ago

Unit Test Results

362 tests 362 :white_check_mark: 12s :stopwatch: 37 suites 0 :zzz: 1 files 0 :x:

Results for commit 680e878d.

:recycle: This comment has been updated with latest results.

megahirt commented 6 months ago

Curiously, after 3 re-runs, the Firefox shard 2/6 playwright E2E tests consistently fail for two tests (they all pass in Chromium):

2 failed [firefox] › editor/editor.entries.spec.ts:207:7 › Editor entries › Create new word, modify new word, autosaves changes, new word visible in editor and list [firefox] › editor/editor.pictures.spec.ts:53:7 › Editor pictures › Showing and hiding captions 17 passed (3.1m)

I'm in favor of merging this with a separate issue to look into the two failing tests

sillsdev / web-languageforge

Update npm packages #1799