sillsdev / web-languageforge

Language Forge: Online Collaborative Dictionary Building on the Web and Phone.
https://languageforge.org
MIT License
44 stars 29 forks source link

debt: suppressImplicitAnyIndexErrors will be disallowed in Typescript 5.5 #1800

Closed rmunn closed 1 month ago

rmunn commented 2 months ago

Describe the code debt We currently have suppressImplicitAnyIndexErrors in our tsconfig.json since we have a lot of implicit any types scattered throughout our code. That option will be going away in Typescript 5.5, so we'll need to turn suppressImplicitAnyIndexErrors off, see where these errors are occurring in our code, and fix them. Typescript says the fix is to "Add an index signature to the relevant type (or use a type assertion at the indexing location)."

To Fix Steps to fix this:

  1. Remove "suppressImplicitAnyIndexErrors": true, from tsconfig.json
  2. Run make
  3. See what Typescript complains about
  4. Fix each error location individually