Prevent sorting by '-audio' citation and lexeme forms

imnasnainaec commented 2 months ago

Fixes issue where words are sorted by audio filenames if the first analysis writing system is an audio one.

Description

The default sort uses the first lexeme form (if no citation form is present) which is a problem if the first analysis writing system is an audio writing system. Then the entries are sorted by the filename, which results in a meaningless sort. This pr prevents '-audio' citation forms and lexeme forms from being used.

Checklist

[x] I have labeled my PR with: bug, feature, engineering, security fix or testing
[x] I have performed a self-review of my own code
[ ] I have reviewed the title & description of this PR which I will use as the squashed PR commit message
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have enabled auto-merge (optional)

Testing

Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.

Describe how to verify your changes and provide any necessary test data.

Test A

imnasnainaec commented 2 months ago

Needs "bug" label added.

megahirt commented 2 months ago

@imnasnainaec note that the two failing e2e tests on Firefox (passes on Chrome) cropped after our npm package upgrade. We haven't figured out why but it's documented I'm not worried and it doesn't have anything to do with your changes.

megahirt commented 2 months ago

@imnasnainaec if you are ready for this to be merged, go ahead and mark it as ready for review and I'll take care to get it published.

imnasnainaec commented 2 months ago

@megahirt The one thing I've not done is describe how testers can test this change. When I tried to create a project with an audio writing system as the first analysis writing system, it didn't come up as first in Language Forge.

rmunn commented 2 months ago

Just merged #1809 into develop, so now I'm merging develop into this PR so that the E2E tests will go green again.

megahirt commented 2 weeks ago

This PR just shipped and I have verified that https://languageforge.org/app/lexicon/5c0ffc0d8b21470bcf09155f sorts properly now with @imnasnainaec 's fix. Thanks!

sillsdev / web-languageforge