After cloning new project, go to project when done

rmunn commented 5 months ago

Fixes #1806

Description

The "Clone new project" page was setting a locationChange event handler to cancel the clone-status timer. However, since the clone-status page counts as a different locaiton, the event was firing as soon as the user pressed the "Get Started" button, cancelling the clone-status timer too soon so the "cloning new project" page was never detecting that the clone completed.

By simply removing the locationChange event handler, we can let the clone status proceed. It changes from "Getting initial data" to "syncing" pretty soon, but that's fine. Once the status goes to idle, the existing code already cancels the timer and loads the project page, so there's no need for any further changes.

Checklist

[X] I have labeled my PR with: bug, feature, engineering, security fix or testing
[X] I have performed a self-review of my own code
[X] I have reviewed the title & description of this PR which I will use as the squashed PR commit message
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have enabled auto-merge (optional)

Testing

Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.

Describe how to verify your changes and provide any necessary test data.

Test A

github-actions[bot] commented 5 months ago

Unit Test Results

362 tests 362 :white_check_mark: 12s :stopwatch: 37 suites 0 :zzz: 1 files 0 :x:

Results for commit d71270b3.

megahirt commented 5 months ago

merged this PR and bypassed the e2e checks which prevented the automerge. The e2e failing checks are firefox only and are not real errors.

sillsdev / web-languageforge