sillsdev / web-languageforge

Language Forge: Online Collaborative Dictionary Building on the Web and Phone.
https://languageforge.org
MIT License
44 stars 29 forks source link

debt: Get rid of Symfony exception-handling patch #1814

Closed rmunn closed 4 months ago

rmunn commented 4 months ago

Is your feature request related to a problem? Please describe. A while back we were having problems with the exception handler in Symfony expecting exceptions to have base class Exception, but receiving base class Error instead. So we created docker/app/symfony-exceptions.patch to fix that. Now we may be able to get rid of that rather hacky solution, as it seems that the exceptions PHP ends up throwing are finally going to be base class Exception.

Describe the solution you'd like Get rid of the hackish symfony-exceptions.patch, finally.

Describe alternatives you've considered Leaving the file in the repo and just commenting out the Dockerfile line that uses it.