sillsdev / web-languageforge

Language Forge: Online Collaborative Dictionary Building on the Web and Phone.
https://languageforge.org
MIT License
44 stars 29 forks source link

Get rid of symfony-exceptions.patch #1815

Closed rmunn closed 1 month ago

rmunn commented 1 month ago

Fixes #1814

Description

We can finally get rid of this hacky "patch a vendor library in place" solution now that PHP exceptions are deriving from the Exception class rather than the Error class.

Screenshots

None; no behavior change.

Checklist

Testing

Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.

Describe how to verify your changes and provide any necessary test data.

github-actions[bot] commented 1 month ago

Unit Test Results

362 tests   362 :white_check_mark:  13s :stopwatch:  37 suites    0 :zzz:   1 files      0 :x:

Results for commit e685f1df.

:recycle: This comment has been updated with latest results.

rmunn commented 1 month ago

@megahirt - Done. I've brought the patch file back, and simply commented out the lines in the Dockerfile that would apply it. So if this exception-swallowing behavior comes back in the future, it'll be obvious from reading the Dockerfile what to do about it.