This will allow the default docker-compose.yml file to build the development build, but allow passing an extra -f flag to docker compose in order to build the production build instead. (This is the Docker Compose equivalent of kustomize, though a little easier to use and understand than kustomize).
Screenshots
Demonstrate any UI / behavioral changes with screenshots or animations.
Checklist
[X] I have labeled my PR with: bug, feature, engineering, security fix or testing
[X] I have performed a self-review of my own code
[X] I have reviewed the title & description of this PR which I will use as the squashed PR commit message
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have enabled auto-merge (optional)
Testing
Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.
Describe how to verify your changes and provide any necessary test data.
Check PR, make sure tests still pass
Edit your Makefile and change the docker compose build steps to include -f docker-compose.yml -f docker-compose.production.yml and make sure running various make commands still works.
Fixes #1821
Description
This will allow the default docker-compose.yml file to build the development build, but allow passing an extra
-f
flag to docker compose in order to build the production build instead. (This is the Docker Compose equivalent of kustomize, though a little easier to use and understand than kustomize).Screenshots
Demonstrate any UI / behavioral changes with screenshots or animations.
Checklist
Testing
Testers, use the following instructions against our staging environment. Post your findings as a comment and include any meaningful screenshots, etc.
Describe how to verify your changes and provide any necessary test data.
docker compose build
steps to include-f docker-compose.yml -f docker-compose.production.yml
and make sure running variousmake
commands still works.