search

sillysloft / fluxbox

Fluxbox Window Manager (Mirror)
http://fluxbox.org/news/
Other
0 stars 1 forks source link

Add missing return to ScreenPlacement.cc #1040

Open sillysloft opened 12 years ago

sillysloft commented 12 years ago

Hi,

I'm packaging fluxbox for openSUSE and planning to add it to openSUSE:Factory (so its part of the next release, 12.2, since 12.1 is already is feature freeze). Our build system has a few checks and it sound a showstopper bug, a missing return (based on compiler warnings) on ScreenPlacement.cc.

Though I'm not an hardcore programmer, I believe the attached patch does fix it (please review and fix upstream).

Furthermore, Ubuntu package ships with a patch to fix FTBFS with GCC4.6. It would be awesoem that patch could also be merged upstream.

Hope it helps, NM

Reported by: *anonymous

sillysloft commented 12 years ago

Original comment by: *anonymous

sillysloft commented 12 years ago

http://git.fluxbox.org/fluxbox.git/commit/?id=3a3df518236cd3cd982e952f63a59cc180c23c38

Original comment by: akir

sillysloft commented 12 years ago

Original comment by: akir