Clock justification wrong until reload style command

[sillysloft]

When the toolbar.justify option is set differently than toolbar.clock.justify, the clock uses the toolbar.justify setting until a Reload Style command is issued. Reload Style must be run to correct this even after a Restart command, not just at initial startup. The workspace, however, does not show this errant behavior and properly respects the setting of toolbar.workspace.justify.

SVN Revision: 4585 Compiled: Aug 18 2006 15:27:27 Compiler: GCC Compiler version: 3.4.6 (Gentoo 3.4.6-r1, ssp-3.4.5-1.0, pie-8.7.9)

Defaults: menu: /usr/share/fluxbox/menu style: /usr/share/fluxbox/styles/Clean keys: /usr/share/fluxbox/keys init: /usr/share/fluxbox/init nls: /usr/share/fluxbox/nls

Compiled options (- => disabled): -DEBUG EWMH GNOME IMLIB2 KDE NLS REMEMBER RENDER SHAPE SLIT TOOLBAR XFT XINERAMA XMB XPM

Reported by: *anonymous

[sillysloft]

Logged In: NO

Still happens in latest svn:

Fluxbox 1.0rc2 : (c) 2001-2006 Henrik Kinnunen

SVN Revision: 4586 Compiled: Sep 5 2006 01:51:36 Compiler: GCC Compiler version: 4.1.1 (Gentoo 4.1.1)

Defaults: menu: /usr/share/fluxbox/menu style: /usr/share/fluxbox/styles/Clean keys: /usr/share/fluxbox/keys init: /usr/share/fluxbox/init nls: /usr/share/fluxbox/nls

Compiled options (- => disabled): -DEBUG EWMH GNOME IMLIB2 KDE NLS REMEMBER RENDER SHAPE -SLIT TOOLBAR XFT -XINERAMA XMB XPM

Original comment by: nobody

[sillysloft]

Logged In: NO

Still in latest svn.

Fluxbox 1.0rc2 : (c) 2001-2006 Henrik Kinnunen

SVN Revision: 4591 Compiled: Sep 21 2006 20:54:53 Compiler: GCC Compiler version: 4.1.1 (Gentoo 4.1.1)

Defaults: menu: /usr/share/fluxbox/menu style: /usr/share/fluxbox/styles/Clean keys: /usr/share/fluxbox/keys init: /usr/share/fluxbox/init nls: /usr/share/fluxbox/nls

Compiled options (- => disabled): -DEBUG EWMH GNOME IMLIB2 KDE NLS REMEMBER RENDER SHAPE -SLIT TOOLBAR XFT -XINERAMA XMB XPM

Original comment by: nobody

[sillysloft]

Logged In: NO

Still in latest SVN:

Fluxbox 1.0rc2 : (c) 2001-2006 Henrik Kinnunen

SVN Revision: 4591 Compiled: Oct 11 2006 12:19:23 Compiler: GCC Compiler version: 4.1.1 (Gentoo 4.1.1)

Defaults: menu: /usr/share/fluxbox/menu style: /usr/share/fluxbox/styles/Clean keys: /usr/share/fluxbox/keys init: /usr/share/fluxbox/init nls: /usr/share/fluxbox/nls

Compiled options (- => disabled): -DEBUG EWMH GNOME IMLIB2 KDE NLS REMEMBER RENDER SHAPE -SLIT TOOLBAR XFT -XINERAMA XMB XPM

Original comment by: nobody

[sillysloft]

Logged In: NO

Still in latest SVN:

SVN Revision: 4597 Compiled: Oct 17 2006 23:09:45 Compiler: GCC Compiler version: 4.1.1 (Gentoo 4.1.1)

Defaults: menu: /usr/share/fluxbox/menu style: /usr/share/fluxbox/styles/Clean keys: /usr/share/fluxbox/keys init: /usr/share/fluxbox/init nls: /usr/share/fluxbox/nls

Compiled options (- => disabled): -DEBUG EWMH GNOME IMLIB2 KDE NLS REMEMBER RENDER SHAPE -SLIT TOOLBAR XFT -XINERAMA XMB XPM

Original comment by: nobody

[sillysloft]

Logged In: NO

Still in latest SVN:

Fluxbox 1.0rc2 : (c) 2001-2006 Henrik Kinnunen

SVN Revision: 4601 Compiled: Oct 31 2006 23:53:56 Compiler: GCC Compiler version: 4.1.1 (Gentoo 4.1.1)

Defaults: menu: /usr/share/fluxbox/menu style: /usr/share/fluxbox/styles/Clean keys: /usr/share/fluxbox/keys init: /usr/share/fluxbox/init nls: /usr/share/fluxbox/nls

Compiled options (- => disabled): -DEBUG EWMH GNOME IMLIB2 KDE NLS REMEMBER RENDER SHAPE -SLIT TOOLBAR XFT -XINERAMA XMB XPM

Original comment by: nobody

[sillysloft]

Logged In: NO

Still in latest SVN:

Fluxbox 1.0rc2 : (c) 2001-2006 Henrik Kinnunen

SVN Revision: 4603 Compiled: Dec 14 2006 04:21:24 Compiler: GCC Compiler version: 4.1.1 (Gentoo 4.1.1-r1)

Defaults: menu: /usr/share/fluxbox/menu style: /usr/share/fluxbox/styles/Clean keys: /usr/share/fluxbox/keys init: /usr/share/fluxbox/init nls: /usr/share/fluxbox/nls

Compiled options (- => disabled): -DEBUG EWMH GNOME IMLIB2 KDE NLS REMEMBER RENDER SHAPE -SLIT TOOLBAR XFT -XINERAMA XMB XPM

Original comment by: nobody

[sillysloft]

Logged In: YES user_id=1538990 Originator: NO

I remember this bug happening, but I can't reproduce it now. It may have been fixed. Can you try it again?

Original comment by: mark-t

[sillysloft]

Logged In: NO

The justification seems to be fixed in "SVN Revision: 4841" but there appears to be a problem with excessive spacing around the clock. I use "session.screen0.strftimeFormat: %a %e %b %l:%M %p" However, I think that there is already another bug open for that issue. If not, I'll open one.

Thank you for fixing the justification issue.

Original comment by: nobody

[sillysloft]

Logged In: NO

Bug #1676914 is about the extra spacing around the clock, but it was closed as fixed in 1.0rc3. However I am still seeing this issue (SVN 4841) with both the included themes (Meta, Operation) and in third party themes. Justification does not seem to matter. I would reopen that bug, but I don't know how. :(

Original comment by: nobody

[sillysloft]

Logged In: YES user_id=603593 Originator: NO

Can we have a screenshot please?

I'd like to get an idea of how excessive this spacing is. I only seem to get a space that looks slightly bigger when the justification is not center. When it's centered, then the extra space is not noticeable (because half is on each side).

Either way, the extra seems to be about 2 wide characters, not particularly huge.

In fact, here's the algorithm for figuring out the size: get the current time string's length, then find out the width of a string with that many, plus two, "0"s (zero characters).

So, I'm guessing that "excessive space" occurs when there are a lot of spaces in the strftime string, as any non fixed-width font has less space used in a space character. We could possibly change the algorithm to use a space character where there's a space, and a zero character where there's a letter/number, though this won't leave a lot of room for errors where chars are wider than a zero. Maybe the two extra chars will be enough though, we could try it...

Thoughts? (other devs, thoughts?)

Original comment by: rathnor

[sillysloft]

Logged In: YES user_id=1538990 Originator: NO

How are we determining where to cut off the titles in TextButtons? Does X11 do that for us? It seems like we should be able to figure out the exact size of the clock using the same algorithm.

Original comment by: mark-t

[sillysloft]

• status: open --> closed-fixed

Original comment by: rathnor

[sillysloft]

Logged In: YES user_id=603593 Originator: NO

The trick is that we are trying to avoid constantly resizing the clock window. So we don't ask for the size of the actual text that is being rendered, rather the size of this zero-filled string. Mind you, the clock sizing has changed a bit over the years, so it might not be worth it any more.

Most (all?) other text buttons are relatively static text. The clock is the only one that changes very regularly (esp if someone has "seconds" in there somewhere). Having it change width affects the whole toolbar, so we really want to minimise that.

However, since the words in the clock change at most once a day, I think the following would be a far better approach: get the current time string. replace all numbers with zeros, get its width, and use that as the width. This allows it to be precise for proportional fonts etc. spaces, colons and other "thin" characters won't be misspaced - the numbers in the string are the only things that'd change "often".

... in fact, I like that so much that I've done it (svn 4844).

Closing bug.

Cheers,

- Simon (observe how idea starts out silly and a bit overcomplicated, but eventually gets there ;-) )

Original comment by: rathnor