search

sillysloft / fluxbox

Fluxbox Window Manager (Mirror)
http://fluxbox.org/news/
Other
0 stars 1 forks source link

fbrun: wrong title font and cyrillic input #702

Open sillysloft opened 17 years ago

sillysloft commented 17 years ago

FluxBox version: 1.0_rc2 xorg-server 1.2.0 xorg-x11 7.2

#set | grep LANG LANG=ru_RU.UTF-8

#fbrun -title "Russian Letters Руские буквы"

And we can not read garbage in window title. And we can not input cyrillic in input box.

In other places everything work fine for russian users.

Thanks.

Reported by: *anonymous

sillysloft commented 9 years ago

Original comment by: akir

sillysloft commented 8 years ago

-title is because FbWindow doesn't set _NET_WM_NAME https://github.com/luebking/fluxbox/commit/4b9701bae78f69ebbbf1eac0e1efae6691de7a82

The input is because TextBox uses Xutf8LookupString and isprint instead of Xutf8LookupString and iswprint Changing that is not very hard (see http://stackoverflow.com/questions/18246848/get-utf-8-input-with-x11-display) but I don't know whether this breaks non utf8 systems.

Are non-utf8 systems relevant and if so, is a (pretty huge) runtime branch preferred over the feature lack?

Original comment by: baghira-style

sillysloft commented 8 years ago

@thomas: you meant XLookup+isprint vs Xutf8Lookup+iswprint, right?

Original comment by: akir

sillysloft commented 8 years ago

Yupp, cnp ;-)

The only real question is whether we need some "#if USE_UTF-8" branch or just mandate UTF-8 (because it's 2016 ;-) This was however before I saw the bsd related bugs. I've frankly no idea whether supporting non UTF-8 setups is (still) required.

Original comment by: baghira-style

sillysloft commented 8 years ago

i quickly glanced over FbTk/FbString.cc and src/FbTk/XmbFontImp.cc .. we have code already which does the "right thing". i am unsure.

you brought up also libinput :)

Original comment by: akir

sillysloft commented 8 years ago

Not entirely, but it provides runtime resolution of utf-8 support (ie. things will work as expected depending on the relevant LC variable. No, I do not know which it is - tried LC_ALL for testing ;-)

https://github.com/luebking/fluxbox/commits/fluexboex

Devil was btw. in the details, ie. "editing" (because chars are suddenly no longer one byte)

PS: where did i bring up libinput??

Original comment by: baghira-style

sillysloft commented 8 years ago

Original comment by: baghira-style