icons skype toolbar

[sillysloft]

the skype's icon on the toolbar are a bit ugly, white, that is my screenshot, you can see above the toolbar that the skype icons are very ugly, in gnome there isn't this problem. Screen: http://img117.imageshack.us/img117/139/schermatafa3.png

Reported by: *anonymous

[sillysloft]

Logged In: YES user_id=697338 Originator: NO

i have this same problem with skype 1.4 or skype 2.0 but not with skype 1.3 so if you need more info about it i can debug it

Original comment by: matteogaliazzo

[sillysloft]

Logged In: YES user_id=1538990 Originator: NO

We already know what's happening. FbTk/Pixmap.cc converts the image to grayscale because the icon they give us is the wrong depth. Search for XCopyPlane. It needs to end up using XGetImage stuff, but I haven't had time. Same goes for some code in FbTk/MenuItem.cc.

Original comment by: mark-t

[sillysloft]

• assigned_to: nobody --> akir
• status: open --> closed-fixed

Original comment by: akir

[sillysloft]

Logged In: YES user_id=1101187 Originator: NO

kind of "fixed" in git now (46fdf4d1b4043588b057fcc9a03f5f66b6b09354). we use _NET_WM_ICON before falling back to old icccm icons (which look like crap for skype, not our fault).

Original comment by: akir

[sillysloft]

reopened:

* _NET_WM_ICON contains argb32 data, see http://standards.freedesktop.org/wm-spec/1.3/ar01s05.html\#id2523482 * we create the _NET_WM_ICON based upon the depth of winclient. * depth of winclient could differ from where we USE the icon: titlebar, menus, iconbar

and that causes the bug for clients such as skype (though they fixed it nowadays) or xfce4-terminal.

Original comment by: akir

[sillysloft]

• status: closed-fixed --> open-accepted

Original comment by: akir

[sillysloft]

improved fix in 1da473bab9fa7b18ae925f8e084465c4c81bc3c9

Original comment by: akir

[sillysloft]

• status: open-accepted --> closed-fixed

Original comment by: akir