search

silnrsi / font-awami

Awami Nastaliq font project
SIL Open Font License 1.1
13 stars 3 forks source link

fstype flag modification #1

Closed n7s closed 6 years ago

n7s commented 6 years ago

Just noticing (from reports in the CI) that the fstype (embedding permissions) probably needs changing from 4 (Preview & Print embedding) to 0.

bobh0303 commented 6 years ago

This may be a defect in our workflow which currently recommends removing openTypeOS2Type from fontinfo. The assumption is that the resulting fsType will be zero -- but it may be that assumption is invalid. Will investigate.

bobh0303 commented 6 years ago

The root cause is that psfglyphs2ufo (used by preflightg) is removing the openTypeOS2Type key from the UFO and it shouldn't.

see https://github.com/silnrsi/pysilfont/issues/52

bobh0303 commented 6 years ago

fixed by https://github.com/silnrsi/font-awami/commit/1390a2db574fe12e5aea9c59e508c9c10ea82187 and https://github.com/silnrsi/pysilfont/commit/2d162a46e954daccd63d76afb4716ad4c355953b

See also ABS-1479