silnrsi / font-ttf-scripts

Font::TTF::Scripts perl module
Artistic License 2.0
19 stars 7 forks source link

make_gdl -d option isn't accepted #6

Closed bobh0303 closed 8 years ago

bobh0303 commented 8 years ago

The -d short-name option gives an error:

me@mine:~$ make_gdl -d LateefReg.ttf x.gdl
Option d, key "LateefReg.ttf", requires a value

The problem has been around since 2012 when -D was added and we changed to use long options. We have the following option specifications:

'autodefines|d',
'define|D=s%', 

but, in the default configuration GetOptions() is case-insensitive. Note that --autodefines works, but -d is treated by GetOptions as --define which requires a key=value parameter.

Some possible approaches:

Either of the first two approaches will break a build that uses uppercase option letters (other than -D) and thus is depending on the case-insensitive nature of the current option parsing.

Neither make_volt nor make_fea currently implement either of these options.

Suggestions welcome.

bobh0303 commented 8 years ago

We've concluded that, since -d is currently broken and many of our projects use --autodefines instead, the safest fix is to take the 3rd option above (remove -d and require the longer --autodefines).