search

silnrsi / graide

GRaphite Integrate Development Environment
GNU Lesser General Public License v2.1
13 stars 2 forks source link

Feature dialog does not handle integer IDs #6

Open sharoncorrell opened 4 years ago

sharoncorrell commented 4 years ago

When you have a feature ID that is defined by id = 1234; it is considered an integer, and the ID is actually the integer 1234. Currently Graide uses (Python) API calls that seem to assume that the integer is an integer form of a 4-char string. This is the FeatureRef::tag() method. When you ask a feature with that kind of ID for its tag, it returns an empty string.

Do we even want to support this kind of ID anymore? The grcompiler is happy with them.

bobh0303 commented 4 years ago

When you have a feature ID that is defined by id = 1234; it is considered an integer, and the ID is actually the integer 1234.

This much I know: the answer is yes.

sharoncorrell commented 4 years ago

I've fixed this so that Graide now gives a message and ignores these features. This might not be want we want long-term.

nrsiward commented 3 years ago

FYI, the above message can be seen if the graide\tests\fonts\charis_r_gr\charis.cfg is used for testing.