search

silnrsi / graphite

Graphite is a "smart font" system developed specifically to handle the complexities of lesser-known languages of the world.
http://graphite.sil.org/
Other
145 stars 44 forks source link

Awami Nastaliq font collision issue #13

Closed wolfbeast closed 7 years ago

wolfbeast commented 7 years ago

On the demo page (http://scripts.sil.org/cms/scripts/page.php?site_id=projects&item_id=graphite_fontdemo) I noticed that the Awami Nastaliq font renders almost correctly in 1.3.10 in Mozilla-based browser code, but it seems one contraction isn't done.

The browser renders: image2

And the graphical example shows: image3

mhosken commented 7 years ago

Renders fine for me on firefox 55. Can you recheck.

wolfbeast commented 7 years ago

Seems to be OK in ESR52 (and you tested 55), however it seems 57 nightly doesn't do this kind of collision fixing at all anymore. (I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1396026 on Firefox for this regression).

I'll have a look into what might be the cause in our own browser which uses the same lib. Possibly it's a problem at a higher level with space contextuals not being honored properly (that would cause this, right?)

wolfbeast commented 7 years ago

I found the problem -- seems it's a Mozilla implementation bug you've participated in, actually ;) The problem being word caching being applied when cross-space contextuals are supported, splitting up the characters because of the space. Easy fix; not a bug in graphite, per se, so closing this issue.