search

silnrsi / graphite

Graphite is a "smart font" system developed specifically to handle the complexities of lesser-known languages of the world.
http://graphite.sil.org/
Other
147 stars 44 forks source link

Update definition of GR_FALLTHROUGH so it is more widely recognized #34

Closed jfkthame closed 6 years ago

jfkthame commented 6 years ago

I noticed that in my local Mozilla build, the GR_FALLTHROUGH macro is not recognized (by compiler "Apple LLVM version 8.0.0 (clang-800.0.42.1)"), with the result that a bunch of unwanted warnings about fallthrough get generated.

Comparing how MOZ_FALLTHROUGH (used elsewhere in Gecko) is defined, I suggest a change such as this, which allows the annotation to be recognized by more compiler versions, and reduces noise in the build log.