Prevent inlining of the direct_run function

silnrsi / graphite

Graphite is a "smart font" system developed specifically to handle the complexities of lesser-known languages of the world.

http://graphite.sil.org/

Other

146 stars 44 forks source link

Prevent inlining of the direct_run function #46

Closed glandium closed 5 years ago

glandium commented 6 years ago

Per CMakeLists.txt, the file can only be built with GCC or clang, so attribute doesn't need to be ifdef'ed away.

jfkthame commented 5 years ago

@mhosken could we get this merged, please? Currently we're carrying it as a local patch in Firefox, which is a nuisance when updating to a new release.

mhosken commented 5 years ago

Sorry about missing this for the release. The PR addresses an important corner case (LTO), but lack of this attribute has not caused problems when building as a library, since testing would soon crash if the function were inlined.