search

silnrsi / graphite

Graphite is a "smart font" system developed specifically to handle the complexities of lesser-known languages of the world.
http://graphite.sil.org/
Other
144 stars 44 forks source link

don't install a libtool file with static library #65

Open ffontaine opened 4 years ago

ffontaine commented 4 years ago

Static library is supported since version 1.3.11 and https://github.com/silnrsi/graphite/commit/2f143c04da5caa43ddf4dba437b2f2bc26bf4238

However, graphite2 is still installing libgraphite2.la which contains incorrect information (i.e. dlname set to libgraphite2.so and old_library set to ''):

dlname='libgraphite2.so'

library_names='libgraphite2.so.3.2.1 libgraphite2.so.3 libgraphite2.so'

old_library=''

dependency_libs=''

This will result in the following build failure with any applications using this file such as harfbuzz:

arm-linux-g++.br_real: error: /home/buildroot/autobuild/run/instance-3/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgraphite2.so: No such file or directory
make[5]: *** [main] Error 1

Instead of trying to fix this libtool file, just disable it when building a static library as it is not needed

Fixes:

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

mgood7123 commented 3 years ago

applied in https://github.com/silnrsi/graphite/pull/69

a17r commented 2 years ago

It is even less justified to have with BUILD_SHARED_LIBS.

mgood7123 commented 2 years ago

It is even less justified to have with BUILD_SHARED_LIBS.

im not sure what you mean