search

silnrsi / grcompiler

The SIL Graphite compiler builds a Graphite enabled font from a smart font description
http://graphite.sil.org
Other
7 stars 3 forks source link

Regression test fails for a font with an explicit name specified #17

Closed sharoncorrell closed 4 years ago

sharoncorrell commented 5 years ago

When a font is generated with an explicit name specified, the date the font was created is stored in certain fields in the name table (see BuildFontNames()). What this means is that the font won't match the benchmark IF it is generated on a different day.

This shows up in the regression tests with the "PigLatin GrRegTest V2" font.

sharoncorrell commented 5 years ago

On Bob's advice, I changed it to only include the year, not the full date. So now this test will only fail when run in a new year. In fact, it should fail if the font name is being regenerated correctly.

bobh0303 commented 4 years ago

no further action needed