silnrsi / grcompiler

The SIL Graphite compiler builds a Graphite enabled font from a smart font description
http://graphite.sil.org
Other
7 stars 3 forks source link

CMake with Ninja code generator failing on Windows #42

Open nrsiward opened 3 years ago

nrsiward commented 3 years ago

If cmake is invoked with the Ninja code generator in Windows 10, the download of ICU fails.

From the build folder: cmake .. -G Ninja

CMake attempts to fetch: https://github.com/unicode-org/icu/releases/download/release-66-1/icu4c-66_1--MSVC2017.zip

("--" should be "-Win64-")

This occurs with Visual Studio 2019 Community Edition with CMake version 3.17.20032601-MSVC_2.

This error also appears in the VS IDE if File - Open - CMake... or File - Open - Folder... is used.

flamenco108 commented 2 years ago

Hello, I want to add just a remark to above: Just replace the address in file CMakeLists.txt from set(ICU_URL https://github.com/unicode-org/icu/releases/download/release-66-1/icu4c-66_1-${_icu_platform_name}-MSVC2017.zip) to full address set(ICU_URL https://github.com/unicode-org/icu/releases/download/release-66-1/icu4c-66_1-Win64-MSVC2017.zip) This will get you further. But then another error occurs:

-- ICU Libraries: 66.1
-- Configuring incomplete, errors occurred!

and I don't know, what to do next :(