search

silnrsi / grcompiler

The SIL Graphite compiler builds a Graphite enabled font from a smart font description
http://graphite.sil.org
Other
7 stars 3 forks source link

Segfault #5

Open bgermann opened 6 years ago

bgermann commented 6 years ago

Commit 4ccd16d7271 introduced a bug that crashes gdlpp. Find the details at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=715950

sharoncorrell commented 5 years ago

We are not including this in the next grcompiler release (v. 5.1).

nrsiward commented 4 years ago

The linked Debian bug report is from 2013 and the attachment there that gives details of the bug is no longer available, so this will not be addressed.

bgermann commented 4 years ago

The bug details are still available and valid for grcompiler 5.2.

bgermann commented 3 years ago

To be more explicit: You run get() without checking for end of file first.

nrsiward commented 3 years ago

This is a test case involving very atypical input which nonetheless should not cause a crash. We need to at least modify the code changed in the commit mentioned above which runs "get() without checking for end of file first".

mhosken commented 3 years ago

Passing this back. Just because I inserted \r handling doesn't mean I am in a position to fix this bug. It's not obvious to me from reading and will require someone with a test setup and debug to dig in and find where the EOF failure is coming in.

get() does EOF checking itself, so there should be no need for eof checking (which is tricky what with macros and #includes) at that point. I can believe the crash but not the proposed diagnostic solution.