silnrsi / langfontfinder

The Find A Font service code
Other
3 stars 2 forks source link

valid tags in langtags return null #18

Open DavidLRowe opened 5 months ago

DavidLRowe commented 5 months ago

GT reports: I ran the mui-language-picker deployment script and it identified the following tags are missing at lff.api.languagetechnology.org/lang: Request failed with status code 404: bap-Krai Request failed with status code 404: elx Request failed with status code 404: gvr-Gukh Request failed with status code 404: kru-Tols Request failed with status code 404: kyw-Chis Request failed with status code 404: suz-Sunu Request failed with status code 404: tcy-Tutg Request failed with status code 404: tyj-Tayo Request failed with status code 404: unr-Onao Request failed with status code 404: wo-Gara

Also: using the und language code to look up the Script tag also doesn't work for these scripts (with elx being the Pelm script).

DavidLRowe commented 5 months ago

IIUC you're expecting that any tag from langtags should return something from the LFF API, even if it is only an empty list. Is that right?

LornaSIL commented 5 months ago

So, I think script2font.csv needs updating to the newest ISO 15924 code additions.

The Pelm one is misspelled in our table and we have a double-entry for Perm which is actually Old Permic.

I don't think there will be fonts yet since all by Pelm are going into Unicode 16.0 (Sept 2024), but I'm happy to update this file with what is available, BUT is this file the authoritative source or is it derived from somewhere else?

DavidLRowe commented 5 months ago

Yes, updates to script2font.csv should be made in this repository. Thanks!

LornaSIL commented 5 months ago

I think this is fixed now. Now the error is LDML SERVER ERROR: No file was found to match your request: elx. which probably means there is no sldr file for it.

DavidLRowe commented 5 months ago

@gtryus Lorna updated the list of scripts and fixed a typo. I don't think the LFF service will return a font for some of these scripts, since there are no fonts listed in the .csv file.