search

silnrsi / langtags

Manage a set of language tag equivalence sets
Other
13 stars 4 forks source link

bug: `"ar-aeb-Arab-TN"` is listed twice in `tags` property of `"aeb-Arab-TN"` #15

Closed mcdurdin closed 4 months ago

mcdurdin commented 4 months ago 
    {
        "full": "aeb-Arab-TN",
        "iana": [ "Tunisian Arabic" ],
        "iso639_3": "aeb",
        "latnnames": [ "Tounsi" ],
        "localname": "تونسي",
        "localnames": [ "تونسي" ],
        "macrolang": "ar",
        "name": "Arabic, Tunisian Spoken",
        "names": [ "Derja", "Tunisian", "Tunisian Arabic", "Tunisian Darija" ],
        "region": "TN",
        "regionname": "Tunisia",
        "regions": [ "BE", "DE", "ES", "FR", "IT", "LY", "NL" ],
        "script": "Arab",
        "sldr": true,
        "tag": "aeb",
        "tags": [ "aeb-Arab", "aeb-TN", "ajt", "ajt-Arab", "ajt-Arab-TN", "ajt-TN", "ar-aeb", "ar-aeb-Arab", "ar-aeb-Arab-TN", "ar-aeb-TN", "aeb-Arab-IL", "ar-aeb-Arab-IL", "ar-aeb-Arab-TN" ],
                                                                                                             ^^^^^^^^^^^^^^^^                                                ^^^^^^^^^^^^^^^^
        "windows": "aeb-Arab"
    },

Emerging from failing tests in https://github.com/keymanapp/keyman/pull/11003

mcdurdin commented 4 months ago

This is caught with the updated schema in https://github.com/silnrsi/langtags/issues/17#issuecomment-2097396072

mhosken commented 4 months ago

Fixed. Generally tags should not duplicate. This was a special due to a hack fix added to the code for that tag. But hey that's why we have tests.