silnrsi / smith

font development, testing and release
Other
14 stars 5 forks source link

installGraphiteFromSource is incomplete #64

Closed bobh0303 closed 3 years ago

bobh0303 commented 3 years ago

Before the initial vagrant up of a focal VM, if I modify provision.sh to enable:

# set to True to compile Graphite and harfbuzz from source (including tracing):
graphiteFromSource=True

then the resulting machine doesn't include hb-shape or hb-view:

vagrant@smith-focal:~$ hb-shape
Command 'hb-shape' not found, but can be installed with:
apt install libharfbuzz-bin
Please ask your administrator.

After executing sudo apt install libharfbuzz-bin the commands were, indeed, present.

It would be good if we could make sure this package is installed from provision.sh.

n7s commented 3 years ago

This conditional has been added a while ago.