search

silnrsi / teckit

A Text Encoding Conversion toolkit
Other
17 stars 11 forks source link

Correct indentation #23

Closed ppisar closed 5 years ago

ppisar commented 5 years ago

GCC 9.1.1 complains:

../SFconv/SFconv.cpp:104:5: warning: this 'while' clause does not guard... [-Wmisleading-indentation] 104 | while (in != end && !(in.error() || out.error())) | ^~~~~ ../SFconv/SFconv.cpp:107:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'while' 107 | if (in.error() || out.error()) { | ^~

This patch fixes it.

devosb commented 5 years ago

Thank you for handling this @tim-eves. I think the code that was patched here was added by you in commit https://github.com/silnrsi/teckit/commit/3e24aa054f51fcdbbcb3adff77d7640d247456b7 and came from the https://github.com/silnrsi/graphite repo. So is there an indentation fix needed from where you took the code from?