search

silnrsi / teckit

A Text Encoding Conversion toolkit
Other
17 stars 11 forks source link

Remove compressed image test #4

Closed jlinton closed 6 years ago

jlinton commented 6 years ago

The binary representation of a compressed block of data can vary depending on small implementation details in the compression library. Lets depend on the tests following the binary image comparison to decompress the .tec file and validate that the compress/decompress logic is functional.

Signed-off-by: Jeremy Linton jeremy.linton@arm.com

devosb commented 6 years ago

Thanks for the fix. I am curious, if I may ask, did you find this from code analysis, or encountering a problem. I appreciate the awareness of the issue, as I intend to upgrade zlib from version 1.2.3 to the latest version 1.2.11 at some point, and you may have saved me from encountering this issue.