Closed sophiebits closed 9 months ago
Hey, thanks for the bug report! This remark plugin is currently incredibly naive, i.e. essentially a hack, so bugs like this are going to show up. I'm out of the open source game for quite a while, unfortunately, but I would very much like this plugin to be smarter. If you'd like to take a stab at this bug I'll be around for code review!
Experiencing this bug as well. Context is something like this...
"**Bolded part** of this quote"
Where the output's left quotation mark is closing, and should be opening. Removing the **
or moving it to outside the quotation marks fixes the issue, but isn't grammatically correct since the bold is only part of the quote.
@sophiebits @silvenon @gene-fls I fixed both cases with a tiny solution 🎉
Hi guys !
It also happens around inlineCode
:
"`code` foo"
I will add some comments on #80
@2wheeh ty for new case, fixed this too!
Your bug reports and fixes rock the house, thanks to you we'll get this released in no time 💪
If I run the following
the output is:
Note that the curly quote before the
google
link goes the wrong way – it's a closing quote but should be an opening one.