search

silverapp / silver

Automated billing and payments for Django with a REST API
https://www.presslabs.com/code/silver/
Other
301 stars 80 forks source link

Initial port to Django 2.1/Python 3. #617

Closed emorozov closed 6 years ago

emorozov commented 6 years ago

Hello guys, Django 1.8 is no longer supported. It's a pain to support a project that is stuck with Python 2/Django 1.8 dependencies.

This is a very quick and dirty port but it's a starting point.

Project starts but not all the features work. Many tests are failing but I'm not sure they aren't broken anyway because the current status on django-silver page shows them as broken also.

I hope it will be at least a good starting point for complete port to Django 2/Python 3.

bogdanpetrea commented 6 years ago

Hi @emorozov,

This looks like a good starting point indeed. And I also agree Python3 / Django2.x support should have happened already.

Build on master is failing because of the docs-theme repo that went missing (accidentally deleted), but otherwise the tests should be passing afaik.

I'll see what is currently broken on your branch and I'll leave a review afterward.

bogdanpetrea commented 6 years ago

The tests are now passing on master and I suggest you do a rebase.

I reread your initial post and forgot to mention that Silver supports Django 1.11 (LTS until ~April 2020), not Django 1.8 which reached it's EOL indeed. Django 2.0 is still supported until April 2019.

Anyway, it might be wiser to make changes one at a time, as in moving the codebase to Python3 first, and then thinking of supporting other Django versions.

We should also investigate how hard it would be to support Django 1.11 and Django 2.x versions at the same time, as there might be some users still depending on Django 1.11.

Let me know what you think @emorozov .

bogdanpetrea commented 6 years ago

Closing this since a different Python3 support branch has been already merged and there lots of conflicts. Feel free to reopen if you feel like adding Django 2.x support.