silverbackhq / silverback

🧬 A Status and Incident Communication Tool (Beta Version).
Apache License 2.0
45 stars 5 forks source link

Add French Translation. #156

Closed Clivern closed 4 years ago

arxcdr commented 4 years ago

Hey there, I can do this one if you want. Is there any special process to follow for contributions or do I just fork, translate and create a PR?

Clivern commented 4 years ago

Thanks @arxcdr for looking into this, As you said fork, translate, create a PR & I will add Hacktoberfest label to your PR then merge.

arxcdr commented 4 years ago

Thanks for confirming @Clivern - I'll get started this afternoon and hopefully should be able to finish the file by the beginning of next week for Hacktoberfest!

arxcdr commented 4 years ago

Actually now that I've looked at the file more closely, I think it might take a bit longer than that but I'll do my best. Are there any restrictions I should be aware of for the translation otherwise (character limit per segment, special characters not to use, etc.)?

Clivern commented 4 years ago

There is no limitations, and we can merge whatever you finish.

arxcdr commented 4 years ago

Perfect, thanks!

arxcdr commented 4 years ago

OK it's going at a good pace, I've translated and spellchecked the first 600 lines already (about 25% of the total). Is it okay with you if I wait till Tuesday to create my PRs so they all count for Hacktoberfest? I'd like to create 4 PRs for roughly 600 lines each.

Clivern commented 4 years ago

of course you can split over 4 PRs & open PRs anytime within october. Anyway i assigned the task to you. Thanks!

arxcdr commented 4 years ago

All right, everything should be there I think. Since I translated from the file directly, it's likely a few minor adjustments may still be needed based on the context where the translated content appears. Maybe in the future these small issues could be logged with screenshots or something when users notice them, and then the translation can be updated as needed.

Happy Hacktoberfest & Good luck with the project!

Clivern commented 4 years ago

Thanks @arxcdr