search

silverbulletmd / silverbullet

The knowledge tinkerer's notebook
https://silverbullet.md
MIT License
2.5k stars 182 forks source link

Plug configuration in SETTINGS are ignored #1078

Closed tmichela closed 1 month ago

tmichela commented 1 month ago

I recently installed a fresh silverbullet and noticed that the generate configuration at SETTINGS changed from yaml to space-config.

It appears that settings for plugs (I tried the git and the treeview plugs) are ignored.
If I change the type of the code block back to yaml all work fine again

moreirapenna2 commented 1 month ago

+1 on this, just started using Silverbullet and a lot of stuff was not working, changing the SETTINGS codeblock from space-config to yaml solved it for me.

zefhemel commented 1 month ago

Please list the plugs this applies to. They need to be updated.

zefhemel commented 1 month ago

Ok, this is causing more problems than I anticipated. I had hoped all plugs would be updated more quickly. In https://github.com/silverbulletmd/silverbullet/commit/e6f010faad7dba7248619a5b336afb43448ff981 I'll revert back to use yaml for now. So from the next release, freshly generated SETTINGS will use the yaml block type again.

moreirapenna2 commented 1 month ago

Please list the plugs this applies to. They need to be updated.

For now, i had this with both AI and TreeView. I'm not sure if it has to do with any of this, but when i had my settings as space-config, i was getting an error on the "indexPage" parameter, saying indexPage must match format "page-ref", and when i changed it to page-ref it said indexPage must be string, which was solved by changing to YAML.

zefhemel commented 1 month ago

@moreirapenna2 that's another issue, the error may not be clear but a page-ref means a string in the form "[[some page]]". So if you put something like "some page" there, this is not an accepted value.

moreirapenna2 commented 1 month ago

@moreirapenna2 that's another issue, the error may not be clear but a page-ref means a string in the form "[[some page]]". So if you put something like "some page" there, this is not an accepted value.

Indeed! Seems like transforming a page-ref into a string by using quotes solves it, thank you!

zefhemel commented 1 month ago

I just noticed the default generated SETTINGS used the wrong format, fixed that too. Releasing 0.9.4 now.