search

silverbulletmd / silverbullet

The knowledge hacker's notebook
https://silverbullet.md
MIT License
2.28k stars 165 forks source link

Dark mode goes away when you switch to sync mode #657

Open devzero opened 7 months ago

devzero commented 7 months ago

I'm not sure if this is intended or not, but is surprising. On a fresh install, switch to dark mode with the command, then click the sync mode button to go offline, once it syncs, it is no longer in dark mode (interestingly it switches back to dark mode when you switch back to online mode). Does it pivot all local editor configs? I noticed that the dark mode settings isn't in settings by default but your state for it sticks with you. Could that be an issue going forward?

zefhemel commented 7 months ago

Hmm odd, would have to check where I track that.

RLB2310 commented 2 months ago

Just wanted to add, It's not just going to Sync mode. Generally I've noticed if I ever clear the cache in my browser it removes the theme until I turn it on again in both modes. If i don't touch the host IP on the server or remove the cache the theme is consistent.

zefhemel commented 2 months ago

The reason is that it's stored per client by design so that you can have different clients with different settings. If you wipe the client the setting is gone.

The sync mode issue I haven't looked into still.