silverbulletmd / silverbullet

The knowledge tinkerer's notebook
https://silverbullet.md
MIT License
2.35k stars 169 forks source link

improve dependency management #770

Closed Maks-s closed 6 months ago

Maks-s commented 7 months ago

This PR seeks to improve how dependencies are managed :

If you feel this is unnecessary, feel free to decline this PR :+1:

zefhemel commented 7 months ago

Yes, thank you for thinking about this and doing this work. I'll look at the details, but I like the general direction. Let me know when you think it's ready to merge.

zefhemel commented 6 months ago

There was a merge conflict with main that I tried to resolve.

When I run this in Firefox things seem to run fine (update: actually only when loading this via localhost not 127.0.0.1), but for whatever in Chrome(like) browsers as well as Safari I see this:

CleanShot 2024-03-09 at 21 07 03@2x

I suspect that a weird import happens somewhere (in the service worker now?) that imports a Deno library that shouldn't be imported... Do you see this too?

Maks-s commented 6 months ago

Thanks for the merge conflict fix

Shoots, I missed that! I'll fix this when I've got some time

zefhemel commented 6 months ago

Ok, this seems to work now. Merging, thanks a lot for this effort!