silverbulletmd / silverbullet

The hackable notebook
https://silverbullet.md
MIT License
2.03k stars 140 forks source link

New font and css fixes #831

Closed onespaceman closed 3 months ago

onespaceman commented 3 months ago

Fix tooltip colors in dark mode Change font to jetbrains mono Preview - styling fixes and follow editor font

zefhemel commented 3 months ago

Thanks for doing this. Now I need some adjusting time. From the screenshots it looked good. Now that it's "real" and I can test it, I have to get used to this new font after looking at iA Writer's for 2 years 😆

zefhemel commented 3 months ago

For those who want to have a look at the difference:

CleanShot 2024-03-26 at 21 02 59

zefhemel commented 3 months ago

Ok let's try. We can always revert.

zefhemel commented 2 months ago

I've been using this for a few days or a week and... not in love to be honest. Maybe I'll revert this. Or somehow we make this an option. Maybe there's a way to serve font files from a space directly so it's easier for people to use their own non-default fonts 🤔

paletochen commented 2 months ago

I've been using this for a few days or a week and... not in love to be honest. Maybe I'll revert this. Or somehow we make this an option. Maybe there's a way to serve font files from a space directly so it's easier for people to use their own non-default fonts 🤔

Same here, It is not the experience I was expecting. I have been using JetBrains Mono for years in my terminal but i cannot make it work (to my eyes) in SB.

I like the original one more

onespaceman commented 2 months ago

I have no opinion on the change because I'm using my own font with space style @import url("https://github.com/iosevka-webfonts/iosevka-term/blob/main/iosevka-term.css"); Google fonts can also be imported this way. Is that a good enough solution?

zefhemel commented 2 months ago

I ended up reverting the font aspect of this in https://github.com/silverbulletmd/silverbullet/commit/82e431d35896c8c175ac12451212d315dd06b57b

Still appreciate the effort of doing this though! :)