Support size for images

silverbulletmd / silverbullet

The hackable notebook

https://silverbullet.md

MIT License

2.03k stars 140 forks source link

Support size for images #833

Closed fflorent closed 1 month ago

fflorent commented 3 months ago

Fixes #493

zefhemel commented 3 months ago

Thanks for this, I’ll have a closer look soon. Bit busy, but you’re not forgotten :-)

zefhemel commented 3 months ago

Is it ready to look at? It’s marked as draft.

fflorent commented 2 months ago

Is it ready to look at? It’s marked as draft.

Sure! Also it is a working version. I just have doubts:

as it is not standard markdown, I have not much opinion about the extension we should implement, though I wonder if there would not be some alternative we could implement and that could be a better fit (like a syntax that could be extended to allow more features, like Kramdown does);
I am not sure when markdown_reader.ts is executed, is it related to the federation feature?

zefhemel commented 2 months ago

Sorry for the delay on this. To answer your question on where markdown_render is used: this is used in a few places:

Markdown preview (Ctrl-p)
Markdown table rendering (when the cursor is not in a markdown table)
Any markdown widget, this includes live templates and live queries

On the latter, an easy way to test this:

```template
Put your ![image](....) here
```

And then move your cursor outside the fenced code block.

In your implementation, you don't currently inject any width and height during markdown_rendering, correct? So this would be something to add. Other than that this looks great!

fflorent commented 1 month ago

@zefhemel Thanks for your answer. I have brought the remaining part of the development.

zefhemel commented 1 month ago

Awesome, thanks a lot!