Feature Request: Add options for PWA manifest customisation

silverbulletmd / silverbullet

The hackable notebook

https://silverbullet.md

MIT License

2.03k stars 140 forks source link

Feature Request: Add options for PWA manifest customisation #838

Closed s1gnate-sync closed 2 months ago

s1gnate-sync commented 3 months ago

To be able to distinguish between multiple instances of silverbullet.

I think it would be great if certain non-critical fields of manifest.json will be customizable:

short_name
name
icon
description

Use-case:

I have installed silverbullet PWA from official website (for documentation) and also hosted my own
It's impossible to distinguish between two instances as name and icon are the same.

s1gnate-sync commented 3 months ago

I can provide a pull-request if you think it's worth implementing :)

zefhemel commented 2 months ago

This would be nice, but how would you imagine configuring it?

s1gnate-sync commented 2 months ago

I see two options:

serve it dynamically + add options to settinga
generate static version

and yeah I'm talking only about self-hosted

1st option is not my fave as it looks wrong to alter manifest after deploy

zefhemel commented 2 months ago

Yeah, I was also thinking of the SETTINGS option, but then it needs to be quite dynamic and that may be tricky. Another option would be to make it configurable via environment variables on the backend and use those when serving the manifest fil.