Table alignments are not working

silverbulletmd / silverbullet

The hackable notebook

https://silverbullet.md

MIT License

2.03k stars 140 forks source link

Table alignments are not working #847

Open katiuskt opened 2 months ago

katiuskt commented 2 months ago

According https://silverbullet.md/Markdown/Extensions I would expect tables alignment to be supported by SilverBullet but it looks like they don't (is always left aligned regardless your MD text):

| Not specified alignment| Centered aligned | Aligned to the right |
| --- | :---: | ---: |
| Test1 | Test1 | Test1 |
| Test2 | Test2 | Test2 |

SilverBullet (docker installation, latest release available 0.7.6) imagen

Same code, another MD editor (snap from obsidian): imagen

zefhemel commented 2 months ago

Indeed, this has not been implemented yet.

djm2k commented 2 months ago

I'm looking at this one, I found another issue with this example where missing | at the start/end of a line should still be parsed as a table. Will open a PR to address the following:

[ ] parseRow does not handle colons : to indicate align HTML properties for table columns
[ ] parseRow does not support a mismatched number of pipes in data rows