search

silveredgold / beta-protection

A flexible and extensible Chrome extension for censoring NSFW images as you view them.
https://silveredgold.github.io/beta-protection/
GNU General Public License v3.0
55 stars 15 forks source link

Browser Crashing #53

Open JuicyStar7 opened 1 year ago

JuicyStar7 commented 1 year ago

Clicking the settings or censoring tab from the pop-up extension crashes my browser. [v0.2.6, Vivaldi]

nisaeggu commented 1 year ago

I have the exact same issue.

guyr1347 commented 1 year ago

I have something similar, trying to change any slider in the options menu freezes my chrome completey (the slider will start teleporting back and forth really quickly). Drop down and checkbox menus work though.

silveredgold commented 1 year ago

Hmm, that's quite unexpected. I've tested Chrome and Vivaldi on my machine and on a sandbox (using v0.2.6 as well) and can't replicate it.

If you reset your settings to default, does it still happen? You can also try uninstalling and reinstalling the extension and test if it still happens? Might be something specific to your settings...

guyr1347 commented 1 year ago

Hmm, that's quite unexpected. I've tested Chrome and Vivaldi on my machine and on a sandbox (using v0.2.6 as well) and can't replicate it.

If you reset your settings to default, does it still happen? You can also try uninstalling and reinstalling the extension and test if it still happens? Might be something specific to your settings...

This happened to me on a stock, new installation

PartTimeDegen commented 1 year ago

If it's anything, I've noticed crashes are more likely to occur if you change settings while the backend is rendering. Also it's likely a crash from memory leaking, I noticed that my browser would mess up after the settings giltch (e.g., can't change tab) then/while my memory usage of chrome (not backend) went up slowly until I killed it.

Not sure if that's anything but I can see an issue pipeline where it's either reading current settings and messing up because it was doing one thing then midway told to do another (so fix would be to hold the settings), or the backend is fighting with the frontend over what settings are used (concurrency issue).

I haven't looked at the code but I would guess that's how it works. I've also had crashes happen when I didn't have the backend active, but the likelihood of crashing would be 50% with it open to 20% with it closed.

silveredgold commented 1 year ago

Hmm, that's good information thanks! Sounds like there might be a problem in saving the settings as each settings change is "round-tripped" to the browser to save settings in real-time. If that gets interrupted, it might be getting stuck in a loop.

Thanks for the information everyone, and I'll see if I can pin down what's happening here.

silveredgold commented 1 year ago

I think I've actually narrowed down the cause for this. I'm testing a fix that should at least stop the crashes, thanks for your patience everyone!