search

silverf0x / RpcView

RpcView is a free tool to explore and decompile Microsoft RPC interfaces
GNU General Public License v3.0
895 stars 247 forks source link

RpcDecompiler/RpcDecompiler.cpp RpcDecompilerPrintHiddenFUProcedure, expression is always false #29

Closed hfiref0x closed 5 years ago

hfiref0x commented 5 years ago

There is an always false expression in RpcDecompiler/RpcDecompiler.cpp RpcDecompilerPrintHiddenFUProcedure function.

The following expression is always false https://github.com/silverf0x/RpcView/blob/c108da277be48accb3c6aaeb4af752a2028069bf/RpcDecompiler/RpcDecompiler.cpp#L496

because bResult was already checked against FALSE at line https://github.com/silverf0x/RpcView/blob/c108da277be48accb3c6aaeb4af752a2028069bf/RpcDecompiler/RpcDecompiler.cpp#L489

and bResult wasn't changed before second check.

Perhaps there is a misprint here or some other variable should be used.