silverfin / silverfin-cli

Command line tool for Silverfin template development
4 stars 1 forks source link

Ensure templateConfig & textPartsReducer is an existing variable everywhere + align number of arguments for create functions with other functions #119

Closed Woetfin closed 6 months ago

Woetfin commented 6 months ago

Description

Some variables were never defined as let or const within the function scope, but this was only throwing errors when using them within the extension.

Additionally, for the bulk command updates using the VS Code extension it's easier if all functions expect the same number of arguments, now there was still a difference here because the "create" commands don't support partner updates and it wasn't needed. Aligned this so we align the code more here instead of adding additional complexity in the logic of the extension.

Type of change

Checklist