silverfin / silverfin-cli

Command line tool for Silverfin template development
4 stars 1 forks source link

Not permitted to update new template #121

Open RomySilverfin opened 6 months ago

RomySilverfin commented 6 months ago

Describe the bug After creating a new reconciliation through the CLI, when I try to update that reconciliation I get an error.

Response Error (422): {"downloadable_as_docx":"found unpermitted parameter: downloadable_as_docx for non externally managed template"} You don't have the rights to update the previous parameters

I authorized the firm again but the issue persists.

To Reproduce Steps to reproduce the behavior:

  1. Create new recon. with the CLI
  2. Update the main.liquid with some code
  3. Run the update command through the CLI or try using development mode
  4. See error

Expected behavior Recon. is updated in the firm

Screenshots or Pull request

Desktop & CLI (please complete the following information):

Additional context

RomySilverfin commented 6 months ago

Workaround: manually remove the downloadable_as_docx parameter from the config.json

Woetfin commented 5 months ago

This should already not happen as often anymore due to engineering update of making externally_managed already able to be set on template creation

RomySilverfin commented 3 weeks ago

It doesn't show the error message anymore, but it's still not possible to update templates created through the CLI without removing the downloadable as docx parameter.

AgustinSilverfin commented 3 weeks ago

It doesn't show the error message anymore, but it's still not possible to update templates created through the CLI without removing the downloadable as docx parameter.

@RomySilverfin Could you provide further details? Is it externally managed? Is it downloadable as docx?

RomySilverfin commented 3 weeks ago

It's exactly the same as I raised earlier, I didn't know this issue was closed. @AgustinSilverfin

I create a template with the CLI, so it's externally managed. I try to update it with the CLI, but nothing happens. Not even an error message. I remove the downloadable as docx from the config file. Then run the update command again. Now it works and I get the message that it was updated through the CLI. I add downloadable as docx back in the file.