search

silverfin / silverfin-cli

Command line tool for Silverfin template development
4 stars 1 forks source link

Avoid text_configuration property overwriting the configuration box on externally managed templates #124

Closed Woetfin closed 6 months ago

Woetfin commented 6 months ago

Describe the bug

the text_configuration is a property that gets returned by default for a template from the API, we didn't do anything special to filter that out because it didn't really do anything before, but with the new config box on externally_managed, it does cause it to overwrite this config box

To Reproduce Steps to reproduce the behavior:

  1. Add configuration to an externally managed template
  2. Add an update from local
  3. Notice this configuration box is overwritten with the value you have in the text_configuration from your config.json

Expected behavior Configuration box for externally managed templates is not being overwritten with what you have locally in the text_configuration property from the config.json

Desktop & CLI (please complete the following information):

Woetfin commented 6 months ago

Should be resolved in version 1.26.6